Skip to content

New Crowdin updates#290

Merged
dm94 merged 15 commits intomasterfrom
l10n_master
Apr 10, 2026
Merged

New Crowdin updates#290
dm94 merged 15 commits intomasterfrom
l10n_master

Conversation

@dm94
Copy link
Copy Markdown
Owner

@dm94 dm94 commented Apr 10, 2026

Summary by Sourcery

New Features:

  • Introduce a configurable NPC selection mode replacing the previous hardcoded 'attack closest' option in gate settings across all supported languages.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 10, 2026

Reviewer's Guide

Replaces the previous 'attack closest NPC' configuration with a more flexible NPC selection mode with multiple options, and updates the corresponding i18n keys consistently across all supported locale property files.

Class diagram for updated NPC selection configuration

classDiagram
    class GateConfig {
        - boolean attackClosest
        + NpcSelectionMode npcSelectionMode
    }

    class NpcSelectionMode {
        <<enumeration>>
        DEFAULT
        ALWAYS_CLOSEST
        NPC_PRIORITY
    }

    GateConfig --> NpcSelectionMode
Loading

File-Level Changes

Change Details Files
Introduce a generic NPC selection mode setting (with multiple options) to replace the old 'always attack the closest NPC' toggle, updating all locale bundles accordingly.
  • Remove the generic_gate.attack_closest and generic_gate.attack_closest.desc translation entries.
  • Add a new generic_gate.npc_selection_mode label and three option keys representing default behavior, always targeting the closest NPC, and an NPC priority mode.
  • Apply these key changes consistently across all localized strings_*.properties files to keep resource bundles in sync.
src/main/resources/com/deeme/lang/strings_bg.properties
src/main/resources/com/deeme/lang/strings_cs.properties
src/main/resources/com/deeme/lang/strings_de.properties
src/main/resources/com/deeme/lang/strings_el.properties
src/main/resources/com/deeme/lang/strings_fr.properties
src/main/resources/com/deeme/lang/strings_hu.properties
src/main/resources/com/deeme/lang/strings_it.properties
src/main/resources/com/deeme/lang/strings_lt.properties
src/main/resources/com/deeme/lang/strings_pl.properties
src/main/resources/com/deeme/lang/strings_pt.properties
src/main/resources/com/deeme/lang/strings_ro.properties
src/main/resources/com/deeme/lang/strings_ru.properties
src/main/resources/com/deeme/lang/strings_sv.properties
src/main/resources/com/deeme/lang/strings_tr.properties
src/main/resources/com/deeme/lang/strings_uk.properties

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The newly added generic_gate.npc_selection_mode* strings are left in English across all non-English locale files; consider either adding translations or explicitly confirming that Crowdin will handle these so users don't see mixed-language UI.
  • Since generic_gate.attack_closest* keys are removed, double-check that all code and configuration references have been migrated to generic_gate.npc_selection_mode* to avoid missing-resource issues at runtime.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The newly added `generic_gate.npc_selection_mode*` strings are left in English across all non-English locale files; consider either adding translations or explicitly confirming that Crowdin will handle these so users don't see mixed-language UI.
- Since `generic_gate.attack_closest*` keys are removed, double-check that all code and configuration references have been migrated to `generic_gate.npc_selection_mode*` to avoid missing-resource issues at runtime.

## Individual Comments

### Comment 1
<location path="src/main/resources/com/deeme/lang/strings_pt.properties" line_range="355" />
<code_context>
-generic_gate.attack_closest.desc=It may work better than the other logic
+generic_gate.npc_selection_mode=NPC selection mode
+generic_gate.npc_selection_mode.list.default=Default
+generic_gate.npc_selection_mode.list.always_closest=Always the closest npc
+generic_gate.npc_selection_mode.list.npc_priority=NPC Priority
 generic_gate.travel_to_next=Travel to the next map
</code_context>
<issue_to_address>
**suggestion (typo):** Use consistent capitalization for the NPC acronym in the new option label.

In other property entries this acronym appears as "NPC"; here it’s lowercase (`npc`). Please update this label to "Always the closest NPC" to match existing UI and locale usage.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread src/main/resources/com/deeme/lang/strings_pt.properties
@dm94 dm94 merged commit 6a96077 into master Apr 10, 2026
8 checks passed
@dm94 dm94 deleted the l10n_master branch April 10, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant