You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @8de2fdb0! Is nice to have this feature updated, I completely overlooked it.
Maybe it's a topic for a different PR, but I suspect (couldn't verify) that the generate_shares function is also cryptographically incorrect (similar to recover_mnemonic, as discussed in #90) and we would be getting a completely different wallet. According to the SLIP-0039 spec, we should't be recovering from the secret that mnemonic_to_bytes returns, but from the 512-bit seed, which would result in 59-word shares.
I'm planning to set up a PR once I find some clearance on this issue.
Said that, for now I think is good to have two separate approach to generate shares: generate_shares_from_secret and generate_shares (from bip39 mnemonic)
Yes the idea of generate_shares_from_secret was to stay backward compatible, but actually use a bip32 seed in byte format. As explained in #90 using the bip39 mnemonic as input is a bit misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the extendable flag for the updated slip39 spec.
Allows for resharable secrets, references:
@alvroble this might be also of interest to you.