docs(secp256k1): document local build loading and submodule init#123
Open
odudex wants to merge 1 commit into
Open
docs(secp256k1): document local build loading and submodule init#123odudex wants to merge 1 commit into
odudex wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the secp256k1 build documentation by adding guidance for initializing the secp256k1-zkp submodule after a non-recursive clone, and by documenting how to make a locally built libsecp256k1 discoverable by embit’s Python ctypes loader.
Changes:
- Add a fallback
git submodule update --recursive --initcommand for existing clones. - Document where
makeoutputs the shared library artifact. - Add steps to symlink the local build into
secp256k1-zkp/.libsand a Python one-liner to verify optional symbols (ECDH + rangeproof rewind) are available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+50
| Run those commands from the `secp256k1/` directory. On macOS, replace the | ||
| `.so` suffix with `.dylib`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan