Skip to content

docs: add pip instructions when using zsh#122

Open
qlrd wants to merge 1 commit into
diybitcoinhardware:masterfrom
qlrd:docs/zsh-pip-readme
Open

docs: add pip instructions when using zsh#122
qlrd wants to merge 1 commit into
diybitcoinhardware:masterfrom
qlrd:docs/zsh-pip-readme

Conversation

@qlrd
Copy link
Copy Markdown
Contributor

@qlrd qlrd commented May 12, 2026

pip install -e .[dev] works fine in sh/bash and (which is what README.md assume). In zsh, unquoted [...] could be interpreted as a glob pattern, so zsh tries to expand .[dev] as a filename match and errors before pip ever runs. This commit add an instruction for zsh with pip install -e ".[dev]" on README.md.

`pip install -e .[dev]` works fine in `sh/bash` and (which is what
`README.md` assume). In zsh, unquoted `[...]` could be interpreted as a
glob pattern, so zsh tries to expand .[dev] as a filename match and
errors before pip ever runs. This commit add an instruction for `zsh`
with `pip install -e ".[dev]"` on `README.md`.
Copilot AI review requested due to automatic review settings May 12, 2026 16:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the development installation instructions in README.md to account for zsh glob expansion behavior, where unquoted .[dev] can be treated as a glob and fail before pip runs.

Changes:

  • Add a zsh-compatible editable install command using quotes around .[dev].
  • Clarify the existing command as applicable to sh/bash-based environments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qlrd qlrd marked this pull request as ready for review May 12, 2026 16:45
@qlrd qlrd requested review from miketlk and odudex as code owners May 12, 2026 16:45
@qlrd
Copy link
Copy Markdown
Contributor Author

qlrd commented May 12, 2026

Duplicates #82, better close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants