18.0 add vcp imp slg

[legalsylvain]

1. [FIX] vcp: set kind field required at platform level. It doesn't makes sense to have a plateform without kind + it makes failing call of update_information

   AttributeError: 'vcp.platform' object has no attribute '_update_information_False'. Did you mean: '_update_information_github'?

2. [FIX] vcp: handle correctly the error, if no API Keys are defined

3. : [REF] vcp: split into vcp and website_partner to make the module more modular.
   Rational: vcp contains a lot of thing that are interesting to use, even if website is not installed
   [ADD] website_partner description and screenshot

description

This module extends the functionality of website_partner module, when vcp module is installed.

It adds on partner website form view, some indicators regarding contributions.

4. [[REF] vcp: split into vcp and website to make the module more modular.

[etobella]

Hi @legalsylvain First two commits for sure are coming in. about the other two, I do agree that it shouldn't depend on website_partner. I did the change at some point in the first PR (OCA#1) but it makes sense to split the logic in 2 different modules. About the split of portal, there I disagree. I understand the comment, but portal is quite common and I don't see the need of the split (if there is a lot of people asking for that split, I don't refuse to do that, but I would like to see other people before 😉)

About the split of partner, I would do it myself (adding you as co-author, obviously), as I want to apply some extra logic to avoid glue-modules if possible.

[legalsylvain]

Hi @legalsylvain First two commits for sure are coming in. about the other two, I do agree that it shouldn't depend on website_partner. I did the change at some point in the first PR (OCA#1) but it makes sense to split the logic in 2 different modules.

Thanks !

About the split of partner, I would do it myself (adding you as co-author, obviously), as I want to apply some extra logic to avoid glue-modules if possible.

thanks !

About the split of portal, there I disagree. I understand the comment, but portal is quite common and I don't see the need of the split (if there is a lot of people asking for that split, I don't refuse to do that, but I would like to see other people before 😉)

Hi.

1. Well, the idea of the splits was to distinguish core / portal / website features.

• core is about backoffice, and provide fetch features. It can be used as a standalone and can be used by many integrators.
• portal (and the same for website) provides specific display for portal users (or public user). It brings some complexity, specific tests, quite a few lines of code, and I guess it will be used by OCA only. (or maybe more companies, but not a lot).

2. Also, I have a V18 instance and I'd like to install vcp on it. (and I don't have portal installed ;-) as it is an only very technical instance, with some back-office module.

[legalsylvain]

closing, as done upstream. Thanks @etobella !