Repository navigation
v0.10.2: Compare Workspace Convergence - #174
Merged
Merged
Conversation
Promote Compare from a transient diff screen into a persistent, resumable operator workspace. - CompareWorkspace is the single workflow owner; CompareContext is the only renderer-facing projection; Analysis is computed exactly once per transition. - Baseline-first: first c establishes the workspace (collapsed preview); second c adds the candidate. - Resumable: Esc preserves the workspace; c on the candidate (▶) re-enters Compare without disturbing the comparison. - Always oriented: shared identity block, verdict, and status-line hints keep orientation visible at every width. - Preview is first-class (verdict + resume hint); navigation converges with Inspect (bracket/Tab/arrows, scroll persists across views). - Simplification: removed dead Status* constants and unrendered m.status assignments. Tests: workflow + behaviour (resume, cross-run pin, clear-preserves-pin, swap) pass; gofmt, vet, build, test, race, staticcheck, golangci-lint green. Closes #173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final convergence of the Compare subsystem: Compare becomes a persistent, resumable operator workspace rather than a transient diff screen.
Changes
CompareWorkspaceis the single workflow owner;CompareContextis the only renderer-facing projection;ComparisonAnalysisis computed exactly once per transition inrefreshAnalysis().cestablishes the comparison workspace (collapsed preview); secondcmerely adds the candidate.Escpreserves the workspace;con the candidate (▶) re-enters Compare without disturbing the comparison (fixes previously-broken resume). AddedTestV0102Workflow_ResumeFromObserve.renderComparisonIdentityBlock(baseline ◆ / candidate ▶), verdict, and status-line hints keep orientation visible below 140 cols.Status*constants and unrenderedm.statusassignments.Views
Overview · Evidence · Diff · Headers · Body · Raw (fixed order via
CompareView, bracket-navigable, all consume the identical immutableCompareContext).Certification
gofmt,goimports,go vet,go build,go test -count=1 ./...,go test -race ./internal/tui/...,staticcheck,golangci-lint,go mod tidy— all green.Docs updated:
COMPARE_CONSTITUTION.md,COMPARE_WORKFLOW.md,RENDERING.md.Closes #173