Repository navigation
Wrap the errors of knex's better-sqlite3 client as database errors - #483
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors of knex's
better-sqlite3client reached apps as the driver'sSqliteError, also in 3.x, so a unique violation wasn't aUniqueViolationError.better-sqlite3throws errors without anerrno, with extended codes likeSQLITE_CONSTRAINT_UNIQUE, and with messages without theSQLITE_CONSTRAINT:prefix ofsqlite3. The SQLite error parsers now accept both, classifying a constraint error by its extended code or by SQLite's own message after the SQL that knex puts in front, so values in the SQL that look like an error message don't change the result. Unit tests run each constraint error in both shapes, as CI doesn't runbetter-sqlite3.