Repository navigation
Name the formats of jsonColumnFormat after the columns, and resolve 'auto' by driver - #481
Merged
Merged
Conversation
lehni
marked this pull request as draft
October 15, 2026 21:34
lehni
force-pushed
the
fix/json-column-format-auto
branch
from
October 15, 2026 21:48
c89e702 to
aa4dd4c
Compare
lehni
changed the title
lehni
force-pushed
the
fix/json-column-format-auto
branch
from
October 15, 2026 21:51
aa4dd4c to
7dc0e33
Compare
lehni
marked this pull request as ready for review
October 15, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonColumnFormatnow names the kind of column that holds the JSON attributes:'auto'(default):'json'on the PostgreSQL drivers,'text'on SQLite and SQL Server,'mixed'on MySQL and others.'json':json/jsonbcolumns that the driver returns parsed; never parsed again (was'parsed').'text': text columns holding JSON; parsed strictly, invalid JSON throws.'mixed': text columns holding JSON or plain text; valid JSON is parsed, other strings are kept.A PostgreSQL
textcolumn holding JSON mixed with plain text had no fitting format before: the default returned the JSON as strings, and'text'threw on the plain text. On SQLite and SQL Server, a string that isn't valid JSON in a JSON attribute now throws where 3.x kept it;'mixed'keeps it. MySQL stays as in 3.x:mysql2returnsjsoncolumns parsed while MariaDB stores JSON as text, which knex can't tell apart. The migration guide leads with ajsonbmigration that keeps plain text rows.