Repository navigation
Resolve Parameters<> of where(), findOne(), whereIn() and select() to their loose arguments in loose mode - #480
Merged
Merged
Conversation
… their loose arguments in loose mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rc.4, the last overloads of
where(),findOne(),whereIn()andselect()are strict-only, so in loose modeParameters<>resolves them tonever, and wrappers that forward their arguments break. 3.9.1 accepted them.The last overload of each now takes the loose arguments in loose mode and stays the strict check in strict mode, where it still reports the errors. The autocompletion overloads are unchanged. In loose mode
whereIn()now forwards all its values, where 3.9.1 only took query builders. Forwardingwhere(column, value)throughParameters<>wasn't possible in 3.9.1 either, as its last overload took an object.Adds type tests for the forwarding in loose and strict mode.