Repository navigation
Make the internal helper types of the typings internal - #475
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ES module typings of 4.0 export what they declare
export, while the 3.x namespace exported every type. The helper types added for the relation expression parser, thewithGraph*()narrowing and the property names aren't meant for users, and are no longer exported:Whitespace,Trim,CountChar,IsBalanced,SplitList,ParseRelationList,ParseRelationString,RelationName,RelationNode,ParseRelationObjectWithGraph,WithGraphPropertyOptionalInsertPropertyNames,InsertablePropertyNames,RelationPropertyNames,InsertableGraphField,InsertableGraphReference,TypedRelationMappingFor,TypedModelClassSpecifier,PartialModelPropsThe unused
ItemTypeis removed.ParseRelationExpression,WithGraphRelations,FetchedRelations,UnnarrowedMethods,WithGraphTreeQueryBuilderandWithResultKindstay exported, as the declarations of inferredwithGraph*()queries name them.The internal checks have consistent names:
UnknownExpressionModifiers,ShouldCheckModifiers,HasOnlyLiteralKeys, which also replaces four inlinestring extends keyofchecks,IsSelectAllandHasModels.Check time
pnpm bench:typings, against next: unchanged.Tests
No type changes apart from the exports: the declarations emitted for a corpus of inferred queries, in loose and strict mode, are the same, with the removed types written out where they were named.
pnpm test:typingspasses with TypeScript 7 and 5.8.3.