Repository navigation
Relate a BelongsToOneRelation model that upsertGraph() gets by its key alone - #473
Merged
Merged
Conversation
lehni
force-pushed
the
fix/relate-without-id
branch
from
October 15, 2026 18:09
98cb63c to
373886f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upsertGraph()withrelaterelates aBelongsToOneRelationmodel without an id that gives the relation's key, e.g.{ id: 1, owner: { code: 'c1' } }for a relation that joinspet.ownerCodetoperson.code, by writing the key to its owner. It then tried to patch that model through its id, and failed with "one of the identifier columns [id] is null or undefined" unlessnoUpdatewas given, also in 3.x. It now writes only the key, without looking up the row, and throws aValidationErrorof typeInvalidGraphbefore anything is written when such a model gives other props that it would write, relations, or an#idthat others refer to. UndernoUpdate, a relation on such a model now throws too, where it was silently left out.