Repository navigation
Admin: Validate color fields on blur and count edits while focused - #390
Merged
Merged
Conversation
- Write the color typed into a color field before the blur validates it - Only count changes as edits while the field is focused, and reset the flag on blur - Focus fields in tests before typing into them, as browsers do - Correct and complete the unreleased changelog entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onBlur()now writes it first.useField()only counts changes as edits while the field is focused, and resets the flag on blur instead of on focus. This states the rule "validate fields on blur that were edited while focused" directly; no field behaves differently.normalizeDataPath()(..right after//throws) andcapitalize()(join table column names), and adds the color fix.