Repository navigation
Conversation
- Nested objects of JSON columns are shared between a record and its JSON, so signing replaced the record's own file objects (#388)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388.
toJSON()signs asset files by writing signed copies into the JSON. WithcloneObjectAttributes = false, nested objects of JSON columns are shared between the record and its JSON, so this replaced the record's ownAssetFileinstances with the signed plain copies._mapAssetFiles()now copies each object and array along a file's path once, then writes the signed file into the copy. The record keeps its own objects and files. Only containers that lead to files are copied.Test: the wildcard signing test also checks that the record's files remain unsigned
AssetFiles aftertoJSON(). It fails without the fix.