Repository navigation
Server: Find asset files through one function, first data path winning - #387
Merged
Merged
Conversation
lehni
force-pushed
the
fix/overlapping-asset-paths-storage
branch
3 times, most recently
from
October 17, 2026 12:03
1ee4b27 to
66082d7
Compare
- Walk a record's asset files location by location in _getAssetFiles(), used for counts, references, loading and signing - Load files that overlapping data paths reach with the first path's storage, where the last one won - Test overlapping data paths on the same storage - Test loading and signing through real models instead of fake ones
lehni
force-pushed
the
fix/overlapping-asset-paths-storage
branch
from
October 17, 2026 12:10
66082d7 to
e927e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #385, which was merged before these review fixes were pushed.
Model._getAssetFiles()walks a record's asset files location by location, and the first declared data path wins. The counts on writes,getAssetReferences(), loading (_forEachAssetFile()) and signing (_mapAssetFiles()) all use it, so the ownership rule exists in one place instead of two.[a, [b]]) were walked recursively when loading. Now only one level is, as counts and references already did. Asset schemas can't produce nested arrays.