Repository navigation
Stop relaying sign-in codes; complete Codex listing metadata - #4
Merged
Merged
Conversation
The skill no longer asks the agent to collect, read, or relay the email sign-in code. With a bundled remote MCP server, sign-in uses that connection; otherwise the user runs `dsp login` in their own terminal, where the CLI asks for the email and code. The agent never runs `dsp login` or `./scripts/login.sh` itself. publish.sh no longer prints the code-relay steps after an anonymous publish, and tests/run.sh now fails if the relay instructions return. The change is canonical for every mount: per-mount text would break the placeholder-free, byte-identical mount invariant in CONTRIBUTING.md. The Codex plugin manifest gains the fields OpenAI's Plugins Directory requires for MCP review (30-character subtitle, capabilities, composerIcon, support/privacy/terms URLs, host-neutral description), and its SVG icon moves to a 64x64 viewBox to meet the 48px minimum. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
carlrannaberg
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're preparing the Codex plugin (
codex/display-dev/) for OpenAI's Plugins Directory, which covers ChatGPT and Codex. OpenAI scans bundled skills automatically, and its plugin guidelines forbid plugins from soliciting "MFA/OTP codes" (Plugin guidelines → Privacy → Restricted data). Our skill told the agent to ask the user for the six-digit email code and pass it todsp login --code. The directory submission also requires listing fields our Codex manifest lacks.Spec (display-dev repo):
engineering/specs/feat-openai-plugin-directory-listing.md, §10.What changes
Sign-in (canonical, every mount)
dsp login --client-source display-dev-skill@0.7.4in their own terminal. The CLI asks for the email and the code there, and SSO organizations open the browser.dsp loginor./scripts/login.shitself, and never asks for, reads, or relays the code. The trust-boundary bullet, the copy section, and thepublish.shpost-publish hint now say the same.tests/run.shgains a "sign-in codes stay with the user" check. It fails on--code,read and provide,provide the six-digitorlogin.sh --emailin SKILL.md or scripts, and requires both prohibition sentences. Every forbidden pattern matches the 0.7.4 files, so the check would have failed on the old text.dsptest double onPATH.Codex manifest (OpenAI listing fields)
shortDescription"Publish and share agent docs" (28 chars; the limit is 30 and the old text was 44).capabilities,composerIcon,supportURL,privacyPolicyURLandtermsOfServiceURLfields, plus a host-neutrallongDescription.assets/logo.svgmoves to a 64×64 viewBox with the same artwork; OpenAI requires square icons of at least 48×48.Decision: canonical, not per-mount
We first considered changing only the Codex mount. That breaks this repo's rule (your 2026-07-22 hardening) that the canonical tree is placeholder-free and every mount is byte-identical, so the change applies to every mount. Trade-off: Claude Code and other CLI users now run
dsp loginthemselves instead of pasting the code into chat. That happens once per machine, since the session is long-lived.Not in this PR
http_headersfrom.mcp.json. Only the directory ZIP build strips it, so the GitHub Codex plugin keeps its attribution.<text>withsystem-ui, so its rendering depends on OpenAI's rasterizer; swap in the brand badge (paths or PNG) before upload.scripts/login.shis unchanged. SKILL.md no longer references it, but the argv-forwarding tests still use it.Verification
bin/sync-mounts.sh --check: 4 mounts match canonical.bash tests/run.sh: exit 0, 10 PASS groups.node --test tests/archive-candidate.test.mjs: pass.jq emptyon all manifests and configs. Manifest fields checked against OpenAI's submission limits; support, privacy and terms URLs return 200.Review
Three independent Fable review rounds. Rounds 1–2 found remaining relay paths (the
publish.shhint, the copy section, a runnablebashfence before the prohibition, the email solicitation) and missing sandbox guidance; all are fixed. The final gate found no blocker, high or medium issues, and its two low wording fixes are applied. The display-dev repo's docs page (website/content/docs/publishing/skill.mdx) and spec are updated separately.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.