Update launcher script to download and call launcher rewrite#891
Open
featheredtoast wants to merge 7 commits intomainfrom
Open
Update launcher script to download and call launcher rewrite#891featheredtoast wants to merge 7 commits intomainfrom
featheredtoast wants to merge 7 commits intomainfrom
Conversation
featheredtoast
force-pushed
the
update-launcher
branch
from
77eb25d to
2d0f6f1
Compare
featheredtoast
force-pushed
the
update-launcher
branch
from
2d0f6f1 to
fce4e3e
Compare
andrewschleifer
requested changes
Jul 24, 2025
featheredtoast
force-pushed
the
update-launcher
branch
from
fce4e3e to
ba0d5d8
Compare
Member
Author
|
The reason for the original complicated flow control logic was an attempt to squelch messaging to stdout for autocompletion messaging (IE, so Additionally: |
featheredtoast
force-pushed
the
update-launcher
branch
2 times, most recently
from
1bbfc24 to
e61df07
Compare
andrewschleifer
approved these changes
Aug 4, 2025
Member
andrewschleifer
left a comment
andrewschleifer
left a comment
There was a problem hiding this comment.
Whitespace issues, otherwise LGTM.
Comment on lines
182
to
193
| case "$1" in | ||
| update) | ||
| echo "updating launcher..." >&2 | ||
| update | ||
| exit 0 | ||
| ;; | ||
| *) | ||
| test -f "${BINDIR}/launcher" || update | ||
| echo "run ./launcher update to update launcher" >&2 | ||
| check_prereqs | ||
| exec "${BINDIR}/launcher" "$@" | ||
| esac |
Member
There was a problem hiding this comment.
This case statement uses mixed tabs and spaces for indentation.
download, checksum and use https://github.com/discourse/launcher support update arg to re-download launcher binary. keep most of the prereqs function in place. check for autocompletion and squelch output if we're calling autocomplete. Remove checks on config existence and config permissions. If we need this check it should go into the launcher app. update overlay check to include overlayfs which is what comes up on default latest docker on desktop versions
Redirect output to stderr.
Ignore check prereqs with $COMP_LINE for autcomplete support.
* Remove discourse docker image download check - this is done in launcher. * update attach check, attach </dev/null for stdin, this can cause open file descriptors to hang around when run when `source`-ing the script.
Reserve stdout for autocompletion. Update the last message to stderr
featheredtoast
force-pushed
the
update-launcher
branch
from
e61df07 to
2cfc2b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download, checksum and use https://github.com/discourse/launcher
support update arg to re-download launcher binary.
keep most of the prereqs function in place. Use hello-world image to check docker install.
check for autocompletion and squelch output if we're calling autocomplete.
Remove checks on config existence and config permissions. If we need this check it should go into the launcher app.
update overlay check to include overlayfs which is what comes up on default latest docker on desktop versions