Merged
Conversation
Templates should be controllable via env var Add `ENABLE_LETSENCRYPT` env var to control when letsencrypt is setup on boot. Add fallback to LETSENCRYPT_ACCOUNT_EMAIL for backwards-compatibility with older config
Ensure that letsencrypt is enabled by default when generated via config
Member
|
will this disable ssl for all sites created recently that don't have it? |
Allow for disabling of letsencrypt template with DISABLE_LETSENCRYPT. Override the disable flag when ENABLE_LETSENCRYPT is explicitly present
This reverts commit 391fb74.
Member
Author
|
Updated so we have disable + enable. Not sure about names, something like require_enable or default_disable for the disabled flag might be better, but not sure what would be the most clear here. |
xfalcox
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DISABLE_LETSENCRYPTenv var to disable letsencrypt from setting up from including the template.Add
ENABLE_LETSENCRYPTenv var to explicitly control when letsencrypt is setup on boot.