chore: remove unused Path::filled/stroked/unpainted constructors - #1248
Open
detail-app[bot] wants to merge 2 commits into
Open
detail-app[bot] wants to merge 2 commits into
detail-app[bot] wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Removed the three
Pathconstructors (Path::filled,Path::stroked,Path::unpainted) fromgeom/store.rs, along with their sole test consumer(
stroked_paths_preserve_line_pattern) and its now-unused imports indialects/artwork/mod.rs.These constructors emitted degenerate empty-shell paths (
Span::EMPTY+BBox::empty()) and had no production callers anywhere in the workspace —path construction goes through
PathArena::push_pathplus struct literals.Orphaned by the geom-substrate restructure that introduced them, and the
file does not exist in the published
crate/pcb-ir/v0.3.82tag, so theywere never released API.
History
Dead Code PRs can be configured here.
Note
Low Risk
Dead-code removal with no production callers; behavior of path construction is unchanged.
Overview
Removes dead
Pathfactory helpersfilled,stroked, andunpaintedfromgeom/store.rs. Those helpers only built empty placeholder paths (Span::EMPTY, empty bbox) and were not used in production; real paths are created viaPathArena::push_pathand struct literals.The artwork dialect test
stroked_paths_preserve_line_pattern(the only caller ofPath::stroked) is deleted, with related test imports trimmed indialects/artwork/mod.rs.Reviewed by Cursor Bugbot for commit eb79502. Bugbot is set up for automated code reviews on this repo. Configure here.