Skip to content

chore: remove unused Path::filled/stroked/unpainted constructors - #1248

Open
detail-app[bot] wants to merge 2 commits into
mainfrom
detail/dead-code/chore-remove-unused-path-filled-stroked-unpainted-ac47d2
Open

detail-app[bot] wants to merge 2 commits into
mainfrom
detail/dead-code/chore-remove-unused-path-filled-stroked-unpainted-ac47d2

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Removed the three Path constructors (Path::filled, Path::stroked,
Path::unpainted) from geom/store.rs, along with their sole test consumer
(stroked_paths_preserve_line_pattern) and its now-unused imports in
dialects/artwork/mod.rs.

These constructors emitted degenerate empty-shell paths (Span::EMPTY +
BBox::empty()) and had no production callers anywhere in the workspace —
path construction goes through PathArena::push_path plus struct literals.
Orphaned by the geom-substrate restructure that introduced them, and the
file does not exist in the published crate/pcb-ir/v0.3.82 tag, so they
were never released API.

History


Dead Code PRs can be configured here.


Note

Low Risk
Dead-code removal with no production callers; behavior of path construction is unchanged.

Overview
Removes dead Path factory helpers filled, stroked, and unpainted from geom/store.rs. Those helpers only built empty placeholder paths (Span::EMPTY, empty bbox) and were not used in production; real paths are created via PathArena::push_path and struct literals.

The artwork dialect test stroked_paths_preserve_line_pattern (the only caller of Path::stroked) is deleted, with related test imports trimmed in dialects/artwork/mod.rs.

Reviewed by Cursor Bugbot for commit eb79502. Bugbot is set up for automated code reviews on this repo. Configure here.

@detail-app
detail-app Bot requested a review from akhilles September 8, 2026 05:52

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: this is a small unused-constructor cleanup, and Cursor Bugbot plus Cursor Security Agent completed with no findings that need human review. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant