[detail-app]

Report a discovery error instead of replacing a descendant package when its URL collides with the root package. Preserve discovered coordinates in the shared resolution map and use that map for reverse lookup, while retaining noncolliding workspace-root package URIs. Add focused regressions for collision handling and URI compatibility.

---

Note

Medium Risk
Changes workspace discovery and package coordinate indexing used for package:// URIs; mis-handling could affect multi-package repos with path-based URLs, though behavior is tightened with explicit errors and tests.

Overview
Fixes a bug where a descendant package named workspace/ could be overwritten by the local root sentinel URL workspace, and where resolution could later stomp discovered coordinates when building package roots.

Workspace discovery now treats a root-package URL collision with an already-discovered descendant as a discovery error (suggesting [workspace].repository), while keeping the descendant package in the map.

Resolution uses or_insert for the workspace fallback root so indexed coordinates are not replaced, and adds package_url_for_package_root to reverse-map a canonical package directory to its coordinate (stdlib, workspace members, sentinel, and cached dependency roots). Regressions cover collision reporting, dependency-root lookup, and round-trip package:// behavior when a workspace/ folder exists.

^{Reviewed by Cursor Bugbot for commit be2ff30. Bugbot is set up for automated code reviews on this repo. Configure here.}

[devin-ai-integration]

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot skipped and reported one unresolved finding, and this is a functional workspace-discovery change rather than a small fixup, so human review is needed. Cursor Security Agent completed successfully with no security findings.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-discovery change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-discovery change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-discovery change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-resolution change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[detail-app]

Re: #1210 (review) — Addressed in e4523e0: the workspace-root fallback in build_package_roots now uses entry().or_insert_with so the sentinel URL is not re-bound over a colliding descendant (crates/pcb-zen-core/src/resolution.rs:247), and package_url_for_package_root resolves roots via the prebuilt indexes.package_roots (crates/pcb-zen-core/src/resolution.rs:807), so a descendant owning the workspace coordinate is preserved. Covered by resolution::tests::workspace_fallback_does_not_replace_discovered_coordinates.

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-resolution change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[cursor]

Stale comment

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-resolution change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[cursor]

Left a non-blocking comment; not approved, and no reviewers were assigned. Cursor Bugbot passed with no unresolved findings, and Cursor Security Agent was not running; this is a functional workspace-resolution change rather than a small fixup, so human review is needed.

  

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}

[detail-app]

Closing this pull request because it has had no human activity in 29 days (since 2026-09-07) and was opened 31 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days.

If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the detail-keep-open label to it.