Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This draft wires in the current fillet-tessellation work from
fillet.The main changes are:
Why
The immediate issue was that curved fillet faces from the OpenCascade golden-master case were not tessellating correctly in our pipeline. The torus annulus lowering path and face orientation handling needed to be fixed so the generated STL matched the intended closed surface behavior.
Impact
QB24031121.stepnow tessellates without the missing curved patches/backface-hole behavior that was present beforeRoot cause
The failing fillet faces were toroidal annuli bounded by closed circular loops, but the old lowering wrapped them poorly in 2D and one recovered annulus still had incorrect winding. That caused CDT failures first, and then backface-culling artifacts even after triangles were emitted.
Validation
cargo run -p gui --release --example test_tessellate -- /Users/lucia/Downloads/QB24031121.step --stl /tmp/qb_downloads.stlcargo run -p triangulate --release --example step_to_stl -- /Users/lucia/Downloads/QB24031121.step --out /tmp/qb_step_to_stl.stlTEST_ASSETS_DIR=/Users/lucia/diode/clickable/data/component_dataset/models RUST_LOG=error cargo run -p gui --release --example regression_test -- --compare /tmp/component_master_baseline.jsonCurrent component-dataset compare vs
master:14751.2msto13978.9ms(-5.2%)1(36907406S.stepon both branches)4609to494225files have worse error counts, with the largest regressions on125_3203_001_A.step,WE-LANAQ_749023310_STP.step,SRP5030CA-4R7M.step,SRP5030CA.step,IC_Texas_Instruments_LM73100RPWR_eec.step, andTCAN3404DRQ1.stepNotes
This should be reviewed as a draft/WIP branch. The QB-specific hole fix is in place, but the component-dataset regressions still need to be worked down before this is ready to merge.
Note
Low Risk
Low risk because changes are overwhelmingly formatting/reordering with no apparent algorithm or API behavior changes; main risk is accidental semantic change in a few reformatted expressions or control-flow blocks.
Overview
Mostly a formatting-only PR. It runs a broad rustfmt-style cleanup across
cdt(examples and core modules liketriangulate,half,hull,contour, andlib) andexpress(examples plusgen.rs), including import reordering, line wrapping, and consistent brace/indent style.A few small readability refactors are included (e.g., wrapping multi-arg calls/closures and normalizing some one-line expressions), but no new functionality or algorithm changes are introduced in the diff.
Reviewed by Cursor Bugbot for commit 0dc3bda. Bugbot is set up for automated code reviews on this repo. Configure here.