Repository navigation
Add Gamma distribution implementation and corresponding tests - #181
Merged
Merged
Conversation
marcelluethi
force-pushed
the
gamma-distribution
branch
from
November 2, 2026 20:27
86a64a1 to
cea44b2
Compare
marcelluethi
force-pushed
the
gamma-distribution
branch
from
November 2, 2026 20:30
cea44b2 to
39a4c03
Compare
benikm91
approved these changes
Nov 3, 2026
benikm91
left a comment
benikm91
left a comment
Collaborator
There was a problem hiding this comment.
Check the scale comment. But looks good
| */ | ||
| class Gamma[T <: Tuple: Labels, V: IsFloating](val concentration: Tensor[T, V], val rate: Tensor[T, V]) extends IndependentDistribution[T, V]: | ||
|
|
||
| private lazy val scale = Tensor.like(rate).fill(1f) / rate |
Collaborator
There was a problem hiding this comment.
Did we think about the trade offs of having this as a private field? Memory vs. Performance
Contributor
Author
There was a problem hiding this comment.
Good point. But I think it is a good trade-off here. And if it turns out to be the wrong trade-off, we can easily change it afterwards without breaking the interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.