[dimslaev]

Step 5 of the backend migration. Stacked on #85.

What moved

• Every tests/ folder is gone, and so is backend/tests/. Each test is now test_<file>.py beside the module it tests.
• HTTP route tests go to entry/api/: test_login, test_users, test_likes, test_articles (was catalog test_routes), test_analytics (analytics test_routes and test_service merged; both went through the client), and test_stories (the route test out of stories).
• entry/cli/test_entrypoints.py is split into test_collect, test_report, test_backup_db, test_seed_articles and test_seed_stories. The unit and shell-script checks stay in test_entrypoints. parents[N] is fixed for the new depth.
• entry/mcp/test_curation_tools.py becomes test_auth.py (the write gate and tokens), plus test_check_link and test_reject_many. test_web_tools is split into test_web_fetch and test_web_search.
• The stories save_story tool test moved to entry/mcp/test_save_story.py. No feature test imports entry or another feature now.
• backend/tests/core/* moved to app/core/ and app/core/db/. test_sanitize was merged into test_llm_text, and test_extract_content is now test_extract. test_db was split: the engine and migrations part is core/db/test_engine.py, and the two tests that need the whole app ("every table in core.db", "routes and collect share the engine") are app/test_main.py. That keeps core tests from importing entry or features.
• tests/test_models_enums.py is now core/db/test_enums.py, with its migrations path fixed.
• collect/test_newsletter_links.py was merged into test_newsletters.py.
• The factories (audience, catalog, random_data) are now app/core/db/factories.py. They write User rows directly instead of calling the audience service, so core.db does not import a feature.
• Shared fixtures moved to backend/conftest.py: auth_client (was in catalog's test file, needed app.main), made (stories cleanup), curator (MCP write scope), and candidate (one pending row).
• pyproject: testpaths = ["app"]. Coverage omits */test_*.py, */conftest.py and */factories.py.
• The moved tests are typed, so cd backend && uv run mypy app (strict) now passes. It had 80 errors on the base.

Counts

• Tests: 659 before, 659 after the move, 690 with the new tests.
• Coverage: 80% before (878 missed lines), 80% after the move (878 missed), 82% with the new tests (801 missed).
• Locally the only failure is /search?q=agents, because the HF model download is blocked here. It passes in CI.

Bug fixes

• fix: fail the daily report when its mail does not send. send_mail caught a failed Resend call and logged it, so the report unit exited 0 with no mail sent. send_report is its only caller and already maps an exception to exit 1. It now raises.

Tests added

• MCP tools: approve (reports and forwards; a refused label is a ToolError and the candidate stays pending), reject (end to end against the ledger; an unknown URL is refused), the error paths of similar, related, draft_issue, save_story and close_story, and save_story updating a story.
• Sign-in: a link request for an inactive user sends nothing and issues no token. An access token for an inactive or deleted user is refused (400 and 404).
• Publisher resolution: owner_kind for Medium, GitHub and Hugging Face (including a failed lookup), hosts_to_publishers skipping non-site links, and feed_sources_from_db, lab_watch_targets_from_db and newsletter_senders_from_db against the db.
• The known-URL filter (collect/filter.py, was 35%): articles, pending rows and rejects are dropped.
• The daily report: read from the db and mailed, and exits 1 when the send fails.

Review findings (code-review, high)

Fixed:

• The report "cannot be sent" test could pass without reaching send_mail. It now asserts the send was tried.
• The filter fixture left its publisher row behind. It now deletes it.

Not changed:

• With no mail env, send_mail still logs and returns, so the report exits 0. That is the intended behavior for dev and CI.
• The report unit has no OnFailure=, so an exit 1 only shows in systemctl --failed and the journal. That belongs with the deploy step (7).
• ADR 4, docs/style.md and docs/backend.md still describe tests/ folders. Step 8 adds the superseding ADR and updates the docs.
• factories.create_user builds User(email=...) without going through UserCreate. That is on purpose, so core.db doesn't import audience.
• Small duplication: test_auth's _as and the curator fixture, and the publisher-plus-article helpers in three story tests.

---

Generated by Claude Code