Skip to content

fix: pino - #373

Open
nigrosimone wants to merge 2 commits into
dimdenGD:mainfrom
nigrosimone:fix-pino
Open

nigrosimone wants to merge 2 commits into
dimdenGD:mainfrom
nigrosimone:fix-pino

Conversation

@nigrosimone

Copy link
Copy Markdown
Contributor

#fix #372

@nigrosimone

nigrosimone commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@dimdenGD

The second commit is not related to the pino fix.

res-connection test was printing res.socket inside the end() callback plus res.writableFinished right after end(). Node changed when the socket is detached, so on Node 24 and 26.8 express prints the socket and false, while on Node 22 it printed null and true. The test failed on main too, before this PR.

Side note: a Node update alone can break it, and we only see it on the next PR. Maybe we could run the tests on a schedule (a montly cron on main), so we find this kind of drift when it happens.

@nigrosimone
nigrosimone marked this pull request as ready for review September 5, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

res.writableEnded is never true — breaks pino-http and any library that relies on Writable stream completion state

1 participant