fix JITMixin pickling - #147
Merged
Merged
Conversation
terencehonles
commented
Sep 24, 2026
| class JITMixin: | ||
| def __reduce__(self): | ||
| # make JITMixin classes pickleable | ||
| return (jit_mixin_type, (self._jit_mixin_base, *self._jit_mixins)) |
Contributor
Author
There was a problem hiding this comment.
This converted all JITMixin instances into classes which will break when the instance was actually used.
millerdev
approved these changes
Sep 25, 2026
millerdev
left a comment
millerdev
left a comment
Contributor
There was a problem hiding this comment.
@terencehonles, Thank you for fixing this!
Contributor
Author
|
No prob, glad you were able to figure out that it was related to #119. I remember seeing the title when looking at the issue list before, but didn't realize that issue would be related to pickling. The copy protocol uses similar lines so it may be using a Any release notes may want to mention this fix includes pickling and deep copies. I didn't add a test with deep copy, but I know pickling uses the copy protocol and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change properly implements the
__reduce__method on theJITMixinclass.