QA-8699 Show View Certificate When The Certificate Is Collapsed

[OrangeAndGreen]

QA-8699

Product Description

On the learning-complete screen, the certificate header now reads "View Certificate" while the certificate is collapsed, and "Certificate" while it is expanded.

Safety Assurance

Safety story

What gives confidence:

• The change is limited to the header label of one view, which is new in 2.65 and not yet released.
• The existing Robolectric toggle test now also checks the label in each state and passes.

Automated test coverage

ConnectLearnCompleteViewTest checks the header label when the certificate starts expanded, after collapsing it and after expanding it again.

🤖 Generated with Claude Code

[OrangeAndGreen]

Suggested Review Order

• app/res/values/strings.xml — the new English label; the other locales repeat it translated
• app/res/layout/view_connect_learn_complete.xml — gives the header label an id
• app/src/org/commcare/views/connect/ConnectLearnCompleteView.kt — switches the label on toggle
• app/unit-tests/src/org/commcare/views/connect/ConnectLearnCompleteViewTest.kt — label checks in the existing toggle test

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 13bc83f8-7a16-40b1-b668-ce5a5700fb63

---

📥 Commits

Reviewing files that changed from the base of the PR and between 861d0bb and 8f03e1c.

---

📒 Files selected for processing (13)

• app/res/layout/view_connect_learn_complete.xml
• app/res/values-es/strings.xml
• app/res/values-fr/strings.xml
• app/res/values-ha/strings.xml
• app/res/values-hi/strings.xml
• app/res/values-lt/strings.xml
• app/res/values-no/strings.xml
• app/res/values-pt/strings.xml
• app/res/values-sw/strings.xml
• app/res/values-ti/strings.xml
• app/res/values/strings.xml
• app/src/org/commcare/views/connect/ConnectLearnCompleteView.kt
• app/unit-tests/src/org/commcare/views/connect/ConnectLearnCompleteViewTest.kt

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The certificate header now displays “Certificate” when expanded and “View certificate” when collapsed. The layout adds an ID for the header label. String resources provide the collapsed label in the default resource set and nine translations. The toggle test checks the label in both states.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: jignesh-dimagi

---

Merge Risk: ⚪ Minimal · up to 8f03e

The change appears limited to the certificate header labels, with both toggle states covered by the described test. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (11 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: showing “View Certificate” when the certificate is collapsed.
Description check		The description covers the user-facing change, ticket, safety rationale, and automated test coverage. It does not include explicit Technical Summary or Labels and Review headings, but the core require…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (11 skipped: 11 unsupported.)

---

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.40%. Comparing base (f4b6c1b) to head (8f03e1c).
⚠️ Report is 7 commits behind head on commcare_2.65.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             commcare_2.65    #3965      +/-   ##
===================================================
+ Coverage            37.32%   37.40%   +0.08%     
- Complexity            6864     6871       +7     
===================================================
  Files                 1034     1034              
  Lines                61094    61102       +8     
  Branches              7472     7473       +1     
===================================================
+ Hits                 22802    22857      +55     
+ Misses               35637    35583      -54     
- Partials              2655     2662       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.