chore(deps): bump the flex-fields packages to 10.0.0-rc.14 - #59
Merged
Conversation
Moves @dignite/ng.flex-fields, its -ckeditor and -file-explorer adapters and @dignite/ng.file-explorer from ^10.0.0-rc.13 to ^10.0.0-rc.14, in both the Host dev app and the published library. The library-side change in rc.14 is CSS only - the Tree control's config and search components stop painting hardcoded light-mode ng-zorro chrome and follow the host theme instead, matching what #57 and #58 did for this repository's own pickers. No API surface moved. The release-side change is the one that matters here. Through rc.13 the two adapter packages declared their intra-repo siblings at "^10.0.0-rc.4"; that range admits an older sibling, and Yarn Classic prefers the latest-tagged version for any range that admits it, so a plain install produced two copies of @dignite/ng.flex-fields - which, FLEX_FIELD_TYPES being a module-scoped InjectionToken, is two distinct DI keys and every field type absent at runtime. rc.14 declares those siblings at the released version. Verified rather than assumed, because abp-modules' own post-publish single-copy check never ran green against rc.14 - it failed on an unrelated npmrc bug in the release workflow, fixed after the tag was cut and never re-run against it. A full re-resolve here with no lockfile and the "resolutions" block removed installs exactly one copy of each of the four packages at rc.14, so the upstream fix does hold. yarn test (29 tests), ng build site and ng build Host all pass. The "resolutions" block is bumped rather than dropped: only the manifest half of the problem is gone. abp-modules still publishes pre-releases under the "next" dist-tag alone, so npmjs' "latest" keeps lagging, and the block makes the single-copy guarantee independent of a dist-tag this repository does not control. check-angular-package-duplicates.mjs is what will say when it has become redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@dignite/ng.flex-fields, its-ckeditorand-file-exploreradapters and@dignite/ng.file-explorerfrom^10.0.0-rc.13to^10.0.0-rc.14, in both the Host dev app andthe published library.
What is actually in rc.14
Library side: CSS only. The Tree control's config and search components stop painting hardcoded
light-mode ng-zorro chrome and follow the host theme instead — the same class of fix #57 and #58
made for this repository's own pickers. No API surface moved, which is why nothing here needed a
code change.
Release side: the half that matters. Through rc.13 the two adapter packages declared their
intra-repo siblings at
^10.0.0-rc.4. That range admits an older sibling, and Yarn Classic prefersthe
latest-tagged version for any range that admits it, so a plain install produced two copies of@dignite/ng.flex-fields.FLEX_FIELD_TYPESbeing a module-scopedInjectionToken, two copies aretwo distinct DI keys:
provideCKEditorFieldType()registers into a tokenFieldTypeResolverneverreads, and every field type is absent at runtime with nothing failing at install or build time.
rc.14 declares those siblings at the released version
(dignite-projects/abp-modules#211).
Verification
The upstream fix was verified here rather than taken on trust, because abp-modules' own post-publish
single-copy check never ran green against rc.14 — it failed on an unrelated npmrc bug in the release
workflow, which was fixed after the tag was cut and never re-run against it.
resolutionsblock removed installs exactly onecopy of each of the four
@dignite/*packages, all at rc.14. The upstream fix does hold on itsown.
check-angular-package-duplicates.mjspasses against the committed tree.yarn test— 29 tests pass.ng build siteandng build Hostboth succeed.Why
resolutionsis bumped rather than droppedOnly the manifest half of the problem is gone. abp-modules still publishes pre-releases under the
nextdist-tag alone, so npmjs'latestkeeps lagging, and a future range wide enough to admit anolder sibling would resolve backwards again. Keeping the block makes the single-copy guarantee
independent of a dist-tag this repository does not control; it now costs a version bump per upgrade
and nothing else.
check-angular-package-duplicates.mjsis what will say when it has becomeredundant rather than load-bearing.
Not covered
No live run of the content editor. The only runtime-visible failure mode — the duplicate-copy DI
split — is ruled out directly by the checks above, and the library diff is CSS.