Fix N+1 query performance issue in Vet.specialties relationship#107
Open
Fix N+1 query performance issue in Vet.specialties relationship#107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Critical N+1 query performance issue in spring-petclinic service affecting
/vets.htmlendpoint with 5 repeated SQL queries instead of optimized batch operations.Issue ID: e8efc2b4-5f5e-11f0-bbd9-0242ac160009
Affected Endpoint: HTTP GET /vets.html
Trace ID: E78ADC1B4AB172AAA6DAC2D716CB4E0D
Solution
Modified the
Vet.specialtiesrelationship configuration to optimize query performance:FetchType.EAGER→FetchType.LAZY@BatchSize(size = 10)annotationorg.hibernate.annotations.BatchSizeChanges Made
src/main/java/org/springframework/samples/petclinic/vet/Vet.java@ManyToMany(fetch = FetchType.EAGER)@BatchSize(size = 10)+@ManyToMany(fetch = FetchType.LAZY)Expected Impact
This fix should reduce the 5 separate SQL queries to a single optimized batch query for the
/vets.htmlendpoint, significantly improving performance.Testing
This follows the same solution pattern that was successfully applied to
Owner.petsrelationship in commit 30fee0f.