Skip to content

FI-686: Signals spec uses environment_id - #1280

Open
nhenning-do wants to merge 2 commits into
digitalocean:mainfrom
nhenning-do:fi-686-openapi-signals-environment-id
Open

nhenning-do wants to merge 2 commits into
digitalocean:mainfrom
nhenning-do:fi-686-openapi-signals-environment-id

Conversation

@nhenning-do

@nhenning-do nhenning-do commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Jira: https://do-internal.atlassian.net/browse/FI-686
Merge order: after FI-680 (cthulhu PR 182108). Re-sync with signals-api before merge.

  • Path/query/body params prefer environment_id; agent_id remains accepted and documented as deprecated (both equal OK; mismatch 400).
  • Response schemas that expose agent_id also dual-emit environment_id with the same value.
  • Paths remain /v1/consent/{…} and /v1/signals/agents/{…}; DigitalOcean-public.v2.yaml path params updated to environment_id.
  • ExportJob.required re-synced with signals-api FI-680: export_id, status, created_at, filters (ids dual-emitted, not required).
  • Tested: make lint; make bundle

Mirror signals-api request/response dual-read and dual-emit of
environment_id alongside deprecated agent_id.
Match FI-680: require export_id, status, created_at, filters; dual-emitted ids stay optional.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants