Skip to content

signals: remove allowed from public consent GET schema - #1258

Merged
RohithSangati merged 3 commits into
digitalocean:mainfrom
nhenning-do:nhenning/strip-signals-allowed
Oct 9, 2026
Merged

RohithSangati merged 3 commits into
digitalocean:mainfrom
nhenning-do:nhenning/strip-signals-allowed

Conversation

@nhenning-do

Copy link
Copy Markdown
Contributor

Summary

  • Drop allowed from agent_consent model, response example, and get-consent description.
  • Public consent GET documents enabled only; allowed remains an internal check-endpoint concept.
    Follow-up to Add Signals API endpoints to OpenAPI spec (FI-610) #1253 after aligning consent-gateway / godo / doctl.

Test plan

  • Spec lint / CI
  • Confirm docs preview no longer shows allowed on GET /v1/consent/{agent_id}

allowed is an internal check-endpoint concept, not returned by
GET /v1/consent/{agent_id}. Document enabled only; drop allowed from
the model, required list, response example, and operation description.

@kjlee27 kjlee27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhenning-do

Copy link
Copy Markdown
Contributor Author

@RohithSangati could you review this as well? update for #1253
backend changes have already deployed. "allowed" should not be surfaced to the customer on public docs as it is not longer surfaced in the api.

@RohithSangati
RohithSangati merged commit 95bf126 into digitalocean:main Oct 9, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants