Skip to content

COBS-1348: Add Insights traces query OpenAPI - #1256

Merged
kishlay-singh-DO merged 6 commits into
digitalocean:mainfrom
srajputdo:sakshirajput/COBS-1348/traces-query-openapi
Oct 9, 2026
Merged

kishlay-singh-DO merged 6 commits into
digitalocean:mainfrom
srajputdo:sakshirajput/COBS-1348/traces-query-openapi

Conversation

@srajputdo

@srajputdo srajputdo commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Document the public Insights traces query endpoints, following the existing logs search pattern.
  • Adds POST /v2/insights/query/{region}/traces/search and GET /v2/insights/query/{region}/traces/{trace_id}.

Testing

  • make lint: 0 errors (only pre-existing warnings outside insights).
  • stage2 (seeded traces on own team): 19 cases pass — search, GET, filters (eq/in/exists/and/not/text_search), orderBy, limits, time formats, 400/404 errors, bad region 404, no-token 401.
  • prod (api.digitalocean.com, team 38134955, nyc2): search/GET 200 with real data; filters eq/neq/or incl. no-match; orderBy asc/desc; limit: 1 → hasMore: true; all error checks match the docs.

Notes

  1. Prod queryrouter routes team 38134955 nyc2/ric1 to the dev querysvc, so the prod check covers Edge → Oceanus → router, not prod querysvc.
  2. Open question: querysvc errors are text/plain while Edge errors are JSON {id, message}. The docs reflect current behaviour.
  3. Compatible with COBS-1347 routing (cthulhu#179827, #180083, #180095, oceanus-manifests#1084).

Add the public traces search and get-by-id operations so they can appear on the official API docs, matching the existing logs search pattern.
- flat filter expressions (type/expressions/field/operator/value/query), lowercase operators
- orderBy direction asc/desc; pagination limit 0-1000 (0 = default 100), no cursor
- time instants accept RFC3339 or unix timestamps; GET supports from/to (default 7d)
- document text/plain service errors (400/404/502) vs JSON edge errors (401/403/404/429)
- list supported regions, single-region only, 60s timeout
- drop region from trace/span models; neutral example names
@srajputdo
srajputdo marked this pull request as ready for review October 9, 2026 10:39
…8/traces-query-openapi

# Conflicts:
#	specification/DigitalOcean-public.v2.yaml
…8/traces-query-openapi

# Conflicts:
#	specification/DigitalOcean-public.v2.yaml
@kishlay-singh-DO
kishlay-singh-DO merged commit 8c0c40c into digitalocean:main Oct 9, 2026
7 checks passed
srajputdo added a commit to srajputdo/godo that referenced this pull request Oct 12, 2026
Add InsightsService.SearchTraces and GetTrace for the public traces query
endpoints documented in digitalocean/openapi#1256.
kishlay-singh-DO pushed a commit to digitalocean/godo that referenced this pull request Oct 12, 2026
Add InsightsService.SearchTraces and GetTrace for the public traces query
endpoints documented in digitalocean/openapi#1256.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants