Skip to content

Add Insights resource signal enablement commands - #2061

Merged
kishlay-singh-DO merged 1 commit into
digitalocean:insights_v2from
dmamidala-glitch:cobs-1782-resource-enablement
Oct 21, 2026
Merged

kishlay-singh-DO merged 1 commit into
digitalocean:insights_v2from
dmamidala-glitch:cobs-1782-resource-enablement

Conversation

@dmamidala-glitch

@dmamidala-glitch dmamidala-glitch commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add doctl insights resource list, get, and update
  • support resource filters, page-based pagination, sorting, and tri-state metrics/logs/traces updates
  • add text and JSON displayers with focused validation and output tests
  • upgrade godo to v1.228.0 for the resource enablement APIs
  • migrate serverless chat content access to the godo v1.228.0 content type without changing behavior

Testing

  • go vet -mod=vendor ./...
  • go test -mod=vendor ./... -run '^$'
  • go test -mod=vendor ./commands -skip '^TestRegistryLogout$' -count=1
  • go test -mod=vendor ./do ./commands/displayers -count=1

References

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@kishlay-singh-DO
kishlay-singh-DO merged commit 11cbd55 into digitalocean:insights_v2 Oct 21, 2026
2 checks passed
SSharma-10 pushed a commit that referenced this pull request Oct 22, 2026
* Add Insights command foundation (#2038)

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add Insights notification channel and alert rule commands (#2043)

* Add Insights alert instance, PromQL, and logs commands (#2044)

* Add Insights alert instance, PromQL, and logs commands

Add doctl insights alert-instance (list, get), metrics (query,
query-range, labels, label-values, series), and logs search commands
backed by the Insights service, with input validation, text and
Prometheus-shaped JSON output, and unit tests.

Related: COBS-1695

* Fix Insights flag help placeholders

pflag treats the first backticked word in a flag's usage as its value
placeholder, which produced help such as --end 2026-09-01T00:00:00Z.
Drop incidental backticks and keep only intentional placeholders.

* Reuse shared Insights helpers from alert rule commands

Use the shared Insights flag names, AddStringArrayFlag and
getInsightsStringArray for --match, readInsightsRequest for logs
request and filter files (adding YAML support), and
rejectRequestFileFlagMix for request-file conflicts.

* Add Insights spans and traces commands (#2047)

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add Insights resource enablement commands (#2061)

Co-authored-by: Cursor <cursoragent@cursor.com>

* COBS-1696: Align Insights tracing wire contract (#2063)

* Align Insights tracing wire contract

Co-authored-by: Cursor <cursoragent@cursor.com>

* Correct Insights tracing filter help

Co-authored-by: Cursor <cursoragent@cursor.com>

* Update godo to v1.230.0

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix Insights logs validation test spelling

Co-authored-by: Cursor <cursoragent@cursor.com>

* Confirm destructive Insights deletes

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: srajputdo <sakshirajput@digitalocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants