Fix default layout TypeError and harden RSS feed against DOM XSS - #136
Fix default layout TypeError and harden RSS feed against DOM XSS#136brettfxio wants to merge 1 commit into
Conversation
- Fix unhandled TypeError in `_layouts/default.html` by adding existence checks for `#paypalDonate` and `#paypalDonateLanding` elements before adding event listeners. - Prevent potential DOM XSS in `_includes/rss_feed.html` by introducing `isValidUrl` helper and validating that feed item links use safe protocols (http: and https:) before rendering View Post buttons. - Implement robust integration test suite under `tests/security_and_robustness.spec.js` to assert default layout error-free load and RSS unsafe link sanitization. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR introduces security and robustness improvements to the Digital Education & Safety Foundation website:
_layouts/default.htmlwhere event listeners were being attached to#paypalDonateelements without prior existence checks. This prevented further script execution on pages using the default layout that lacked these buttons._includes/rss_feed.html) against DOM XSS. It adds a protocol-based URL validatorisValidUrlthat filters out dangerous protocols (e.g.,javascript:) before generating 'View Post' action buttons.tests/security_and_robustness.spec.js) to guarantee correct behavior and prevent regressions.PR created automatically by Jules for task 13797679000729918439 started by @brettfxio