Object-Based Screen Swipe Events - #224
Conversation
- Update the `event_on_swipe` block definition to accept an `OBJECT_SELECTOR` input, allowing specific objects to register for and receive swipe events. - Update the block generator to compile target meshes as lazy-evaluation arrow function getters, using a static `thisMesh` parameter name to completely eliminate JavaScript compilation syntax errors under shadow or empty block states. - Refactor `onSwipe` and `triggerSwipe` inside `BabylonSceneManager` to resolve and get meshes dynamically using `_resolveTarget` and `_getMesh`. - Update `_workspaces/endless-runner.md` with the new block input configuration mapped to `player_var`. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change refactors the event_on_swipe event block from a global screen-level swipe listener to an object-specific swipe listener, perfectly matching standard Blockly event design and resolving race conditions during asynchronous scene initialization.
PR created automatically by Jules for task 15321287743512529999 started by @brettfxio