Validate popup image URLs with isValidAssetURL in UIManager and BabylonSceneManager - #199
Validate popup image URLs with isValidAssetURL in UIManager and BabylonSceneManager#199brettfxio wants to merge 2 commits into
Conversation
… BabylonSceneManager Only allow secure URLs (HTTPS, blob, data) for popup images to prevent insecure image loading. Add a comprehensive security validation integration test suite. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
… BabylonSceneManager Only allow secure URLs (HTTPS, blob, data) for popup images to prevent insecure image loading. Add a comprehensive security validation integration test suite, and eliminate flakiness in features jump test. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
1 participant
This PR introduces strict secure URL validation for popup images using the existing
isValidAssetURLhelper. Image URLs used increatePopupandsetPopupImageare now checked, ignoring invalid or insecure (HTTP) URLs. A dedicated Playwright test suitetests/popup_security.spec.jsis added to verify the validation logic, ensuring zero regression and robust error-handling.PR created automatically by Jules for task 2604262148542140071 started by @brettfxio