Fix trailing semicolons and newlines in value block generators - #197
Fix trailing semicolons and newlines in value block generators#197brettfxio wants to merge 1 commit into
Conversation
Remove trailing semicolons and newlines from the code expression returned by `create_ground` and `parse_number_from` Blockly block generators. In Blockly, custom value blocks must return only the expression string to ensure proper nesting and code generation. Add Playwright integration tests in `tests/value_block_generators.spec.js` to prevent regressions. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This pull request fixes a code generation bug in
create_groundandparse_number_fromblock generators where trailing semicolons and newlines were appended to value blocks. It includes a comprehensive Playwright test suite to verify correct code generation.PR created automatically by Jules for task 14444470530272230519 started by @brettfxio