Improve Scene Logic and Add Light Property Controls - #188
Conversation
feat: add light property control block - Updated playerJump raycast length for better precision. - Refactored destroyObject to correctly handle direct mesh objects and ensure removal from tracking map. - Added set_light_property Blockly block to allow changing light intensity and color. - Implemented setLightProperty in BabylonSceneManager. - Added Playwright tests for light property modifications. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR introduces several improvements to the 3D engine:
playerJumpfrom 0.8 to 0.1, preventing the player from jumping while slightly above the ground.destroyObjectand_getMeshto correctly handle direct Babylon.js mesh instances and ensure they are properly removed from the internal object tracking map.tests/light_properties.spec.jsto verify the new block and its integration with the engine. Verified all tests pass.PR created automatically by Jules for task 8717262148381302904 started by @brettfxio