Repository navigation
Conversation
Since pytest 9.2.0, monkeypatch.setattr restores only what was in the instance __dict__; Starlette's State keeps its values in _state, so the undo deleted gh_token_minutes and the next test on the same worker failed in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pytest 9.2.0, monkeypatch.setattr undo deletes attributes that are not in the instance dict; Starlette's State keeps its own, so CI failed on the v0.6.4.2 tag. The test now restores the value itself. tests/api passes under pytest 9.2.0 with -n auto.