Fjerner credentialId, valid-from og valdi-until fra VCNotice#93
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes fields from the verifiable-credential notice data type and updates the public schema/docs/examples to reflect the simplified VerifiableCredentialNotice and VerifiablePresentationNotice structures.
Changes:
- Removed
credentialId,validFrom, andvalidUntilfromVerifiableCredentialNotice(Java + docs/examples). - Simplified
VerifiablePresentationNoticedescription and removed query-related documentation/schema elements. - Updated
datatypes.xsd,readme.md, anddatatypes-examples.xmlto match the new structures.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/no/digipost/api/datatypes/types/verifiableCredential/VerifiablePresentationNotice.java | Updates the datatype description for VP notice. |
| src/main/java/no/digipost/api/datatypes/types/verifiableCredential/VerifiableCredentialNotice.java | Removes credential id and validity fields; updates XML ordering and example. |
| readme.md | Removes the deleted fields from VC notice docs and simplifies VP notice docs/examples. |
| datatypes.xsd | Removes VC notice fields and removes VP query-related schema structures. |
| datatypes-examples.xml | Updates example XML instances to match the new schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Retter også noen gjennhengende feil i VPNotice
eirikolberg
force-pushed
the
remove-claims-and-template
branch
from
9862824 to
4c5dd0c
Compare
henning-digipost
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retter også noen gjennhengende feil i VPNotice