story/HOP-65#52
Open
Girik1105 wants to merge 4 commits into
Open
Conversation
|
Can one of the admins verify this patch? |
Member
|
Make it so, Jenkins. |
jdamerow
requested changes
May 22, 2026
| continue | ||
| root, ext = os.path.splitext(os.path.basename(resource.file.name)) | ||
| resource.original_filename = f"{_STORAGE_SUFFIX.sub('', root)}{ext}" | ||
| resource.save(update_fields=["original_filename"]) |
Member
There was a problem hiding this comment.
There is an issue with underscores here. The files I'm uploading have blanks in them which seem to be replaced with _. So after this the original filename will have _ instead of blanks, but it seems like when uploading a file, the original filename will still have the blanks.
I don't think we need this function at all though since we currently don't have a prod. I'll just remove everything before uploading the first time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
more zip upload changes
Description
On the upload page, the heading appears twice:
When a file that already exists is being uploaded, it should be ignored. I’ll create a second ticket to enable overrides.
HOP-65
Anything else the reviewer needs to know?
Does this Pull request depend on any other?