Chore/migrate credo 0.6.x by rmlearney-digicatapult · Pull Request #490 · digicatapult/veritable-cloudagent

rmlearney-digicatapult · 2026-03-02T14:52:20Z

Pull Request

Checklist

Have you read Digital Catapult's Code of Conduct?
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

High level description

Migrate to credo-ts v0.6.x

Detailed description

This is the big one. Changes throughout the codebase to migrate types, controllers, events, agent init to credo-ts v0.6.x.

Minimal changes to the test suite with new tests added for credo-ts v0.6.x behaviours around askar and JSON-LD

Migration notes in credo-v0.6-migration-release-notes.md

Describe alternatives you've considered

Operational impact

Additional context

This is a breaking change and downstream consumers (UI, encryption service) will need to migrate

- align did:web generator/tests with current v0.6 branch key representation - update integration tests for v0.6 OOB label requirement and DID create payload - migrate unit helper offer naming to credentialExchangeRecord - keep credential event contract on credentialExchangeRecord and validate with unit suite Docs updated in /Users/rlearney/git/veritable-improvements/credo_migration: 04_controllers_and_events.md, 05_didweb_canonical_v0.6_plan.md, MASTER_MIGRATION_PLAN.md

Copilot

Pull request overview

Copilot reviewed 81 out of 82 changed files in this pull request and generated 2 comments.

src/controllers/v1/agent/AgentController.ts

src/controllers/v1/wallet/WalletController.ts

Copilot

Pull request overview

Copilot reviewed 82 out of 84 changed files in this pull request and generated 7 comments.

src/controllers/v1/credentials/CredentialController.ts

src/error.ts

src/controllers/v1/outofband/OutOfBandController.ts

README.md

docs/credo-did-documents-v0.5-v0.6.md

src/controllers/v1/outofband/OutOfBandController.ts

docs/credo-v0.6-migration-release-notes.md

Copilot

Pull request overview

Copilot reviewed 84 out of 86 changed files in this pull request and generated 1 comment.

src/modules/verified-drpc/models/ValidRequest.ts

Copilot

Pull request overview

Copilot reviewed 87 out of 89 changed files in this pull request and generated 1 comment.

src/error.ts

rmlearney-digicatapult added 26 commits February 27, 2026 13:29

chore: migrate credo 0.6 phase 1 wiring and verified-drpc module API

76e1f3c

chore: complete phase 2 wallet and didweb KMS migration

8db841c

feat: complete phase 3 didcomm controller and event migration

048b93a

chore: complete Credo 0.6 migration and stabilize unit tests

a3658f0

fix: pin node-addon-api for Node 24 Docker builds

b28ad92

test: update credential test setup

5ac9042

test: align integration suite with credo v0.6 contracts

00b2253

unit test for required label in oob

9caec67

refactor(oob): enforce credo label contract across invitation paths

5bd08cb

docs: note OOB label requirement in v0.6 migration notes

a886776

Align v0.6 type contracts and consolidate migration docs

d86cc9e

Refine controller type boundaries and naming consistency

7c7f71e

Converge DID resolution typing to Credo result model

a7d64af

Refactor DID create-state DTOs with shared base

37a4c1e

Finalize Phase 9.3 docs and proof boundary notes

df5e2d7

chore: patch credo loaders and pex via postinstall

c16ae9a

fix: copy credo patch script before npm ci in docker

dee7775

test: stabilize did:web w3c credential flow on credo 0.6

11f1f17

Harden PEX accept-request input and redact PEX selections

b38b3d4

Add bootstrap idempotence tests and clarify Askar KMS migration notes

3e5d8b9

migration documents

954cb7d

Add shape-based JSON-LD validation and document boundary policy

2f4f59c

Align JSON-LD credential validation to 400 and sync docs/tests

fac810c

version bump

76b491f

migration note

a6c4fbf

Copilot AI review requested due to automatic review settings March 2, 2026 14:52

rmlearney-digicatapult requested a review from a team as a code owner March 2, 2026 14:52

Copilot started reviewing on behalf of rmlearney-digicatapult March 2, 2026 14:52 View session

rmlearney-digicatapult marked this pull request as draft March 2, 2026 14:53

rmlearney-digicatapult added the v:minor Change requires a semver minor version change label Mar 2, 2026

rmlearney-digicatapult requested a review from Copilot March 2, 2026 19:55

Copilot started reviewing on behalf of rmlearney-digicatapult March 2, 2026 19:55 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

src/controllers/v1/agent/AgentController.ts Outdated Show resolved Hide resolved

src/controllers/v1/wallet/WalletController.ts Show resolved Hide resolved

rmlearney-digicatapult added 3 commits March 2, 2026 20:21

refactor(wallet): centralize compact JWE base64url validation

b8bfd14

chore(migration): align agent config reads with credo v0.6

06f24e1

chore(esm): align tsconfig and migration notes

f2ccce0

rmlearney-digicatapult requested a review from Copilot March 2, 2026 20:45

Copilot started reviewing on behalf of rmlearney-digicatapult March 2, 2026 20:45 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Align BadRequest contract and close remaining PR review items

b5ce92c

rmlearney-digicatapult requested a review from Copilot March 3, 2026 13:06

Copilot started reviewing on behalf of rmlearney-digicatapult March 3, 2026 13:07 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/modules/verified-drpc/models/ValidRequest.ts Show resolved Hide resolved

rmlearney-digicatapult added 4 commits March 3, 2026 15:01

Fix verified-dRPC validation and enforce jsonrpc 2.0

515c2f9

docs

8a8988a

Refactor DidComm naming cleanup and document migration

9e5196e

Restore UUID typing for credential connectionId fields

56f77ae

rmlearney-digicatapult marked this pull request as ready for review March 3, 2026 15:34

rmlearney-digicatapult requested a review from Copilot March 3, 2026 15:41

Copilot started reviewing on behalf of rmlearney-digicatapult March 3, 2026 15:41 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/error.ts Show resolved Hide resolved

rmlearney-digicatapult added 8 commits March 3, 2026 16:08

migration docs

570fd1a

Align error response objects with OpenAPI annotations

4f65f76

chore: upgrade credo-ts to 0.6.3 and remove patch script

0a548f0

doc cleanup

592cb0a

remove patch from dockerfile

faedfa0

Align 422 errors with UnprocessableEntityError

926196b

remove patch

2912c4e

remove askar-shared

d7aeff4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/migrate credo 0.6.x#490

Chore/migrate credo 0.6.x#490
rmlearney-digicatapult wants to merge 46 commits intomainfrom
chore/migrate-credo-0.6.x

rmlearney-digicatapult commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rmlearney-digicatapult commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Checklist

PR Type

Linked tickets

High level description

Detailed description

Describe alternatives you've considered

Operational impact

Additional context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rmlearney-digicatapult commented Mar 2, 2026 •

edited

Loading