EOF error on delete - #559
Open
breardon2011 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oc exec killprints "Error: EOF" even though the server killed the session cleanly — the kill endpoint returns 204 No Content, but Client.Get/Post/Patch/PutJSON always calljson.Decode(result), which returns io.EOF on an empty body.Added a
decodeIfBody(resp, result)helper: no-op when status is 204/205 or Content-Length is 0, else decode as before. Applied to all four methods.Verified on dev:
oc exec kill sb-… sess-…now prints "Session … killed" and exits 0.