[rewrite] apply `ECMAScript6BestPractices` by Pankraz76 · Pull Request #2768 · diffplug/spotless

Pankraz76 · 2025-11-24T09:40:04Z

nice to see rewrite also fixing .js stuff as well.

Changes have been made to lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js by:
    org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
        org.openrewrite.codemods.ecmascript.5to6.varToLet
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/let.js}
        org.openrewrite.codemods.ecmascript.5to6.amdToEsm
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/amd.js}
        org.openrewrite.codemods.ecmascript.5to6.cjsToEsm
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/cjs.js, codemodArgs=[hoist=true]}
Changes have been made to lib/src/main/resources/com/diffplug/spotless/npm/eslint-serve.js by:
    org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
        org.openrewrite.codemods.ecmascript.5to6.cjsToEsm
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/cjs.js, codemodArgs=[hoist=true]}
Changes have been made to lib/src/main/resources/com/diffplug/spotless/npm/prettier-serve.js by:
    org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
        org.openrewrite.codemods.ecmascript.5to6.cjsToEsm
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/cjs.js, codemodArgs=[hoist=true]}
Changes have been made to lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-serve.js by:
    org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
        org.openrewrite.codemods.ecmascript.5to6.varToLet
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/let.js}
        org.openrewrite.codemods.ecmascript.5to6.cjsToEsm
            org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/cjs.js, codemodArgs=[hoist=true]}
Please review and commit the results.
Estimate time saved: 20m

Pankraz76 · 2025-11-24T10:32:27Z

 const debug_serve = false; // set to true for debug log output in node process
-const shutdownServer = require("http-graceful-shutdown");
-const express = require("express");
+// this file will be glued to the top of the specific xy-serve.js file


moving here as its a bug to rewrite.

endless copying the comment every run:

// this file will be glued to the top of the specific xy-serve.js file // this file will be glued to the top of the specific xy-serve.js file // this file will be glued to the top of the specific xy-serve.js file // this file will be glued to the top of the specific xy-serve.js file

Pankraz76 · 2025-11-24T13:14:04Z

might be IO-flaky CI:

5-11-24 13:02:31] Identified 17.0.17 as the newest version of Java supported by the version of Gradle in use. The system default of 17.0.17 is compatible with this.
  [2025-11-24 13:02:31] [autobuild] > ./gradlew --no-daemon -S -Dorg.gradle.dependency.verification=off -Dorg.gradle.warning.mode=none --init-script "/tmp/semmleTempDir11433629524650825132/init.gradle" clean
  [2025-11-24 13:02:31] [autobuild] Picked up JAVA_TOOL_OPTIONS:  -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
  [2025-11-24 13:02:32] [autobuild] Downloading https://services.gradle.org/distributions/gradle-9.2.1-bin.zip
  [2025-11-24 13:02:37] [autobuild] Exception in thread "main" java.io.IOException: Server returned HTTP response code: 503 for URL: https://services.gradle.org/distributions/gradle-9.2.1-bin.zip
  [2025-11-24 13:02:37] [autobuild] 	at org.gradle.wrapper.Install.forceFetch(SourceFile:2)
  [2025-11-24 13:02:37] [autobuild] 	at org.gradle.wrapper.Install$1.call(SourceFile:8)
  [2025-11-24 13:02:37] [autobuild] 	at org.gradle.wrapper.GradleWrapperMain.main(SourceFile:67)
  Error: 1-24 13:02:37] [ERROR] Spawned process exited abnormally (code 1; tried to run: [./gradlew, --no-daemon, -S, -Dorg.gradle.dependency.verification=off, -Dorg.gradle.warning.mode=none, --init-script, /tmp/semmleTempDir11433629524650825132/init.gradle, clean])
  Error: We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps. Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.23.5/x64/codeql/java/tools/autobuild.sh". Exit code was 1 and last log line was: Picked up JAVA_TOOL_OPTIONS:  -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false. See the logs for more details.

Pankraz76 · 2025-11-24T13:14:43Z

 public class NpmTestsWithDynamicallyInstalledNpmInstallationTest extends MavenIntegrationHarness {

 	@Test
+	@Disabled


why this one failing, please?

item:

at app//com.diffplug.gradle.spotless.NpmTestsWithoutNpmInstallationTest.useNpmFromNodeGradlePlugin_example2(NpmTestsWithoutNpmInstallationTest.java:94)

Pankraz76 · 2025-11-27T11:36:15Z

consider reopen.

Pankraz76 · 2025-11-28T16:00:21Z

-const shutdownServer = require("http-graceful-shutdown");
-const express = require("express");
 const app = express();
+const express = require("express");


somehow we can not do the imports here. why so?

its the same env and runtime right?

import tsfmt from

Signed-off-by: Vincent Potucek <vpotucek@me.com>

…-common-serve' into fix-ECMAScript6BestPractices-fix-common-serve # Conflicts: # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js

…-ECMAScript6BestPractices # Conflicts: # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js

Signed-off-by: Vincent Potucek <vpotucek@me.com>

…to fix-ECMAScript6BestPractices # Conflicts: # gradle/rewrite.gradle # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js # lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-serve.js

Pankraz76 · 2025-12-03T12:00:53Z

reopen after enabler

Pankraz76 force-pushed the fix-ECMAScript6BestPractices branch 2 times, most recently from e8c21f3 to 9fdd689 Compare November 24, 2025 09:45

Pankraz76 mentioned this pull request Nov 24, 2025

Issue #17487: Add ECMAScript6BestPractices checkstyle/checkstyle#18158

Closed

Pankraz76 force-pushed the fix-ECMAScript6BestPractices branch from 9fdd689 to dedb8c8 Compare November 24, 2025 10:31

Pankraz76 commented Nov 24, 2025

View reviewed changes

Pankraz76 mentioned this pull request Nov 24, 2025

ECMAScript6BestPractices endless comment copy bug. openrewrite/rewrite#6330

Open

Pankraz76 commented Nov 24, 2025

View reviewed changes

This was referenced Nov 27, 2025

ECMAScript6BestPractices checkstyle/checkstyle#18198

Closed

[ECMAScript6BestPractices] fix common-serve.js #2773

Closed

Pankraz76 closed this Nov 27, 2025

Pankraz76 reopened this Nov 28, 2025

Pankraz76 force-pushed the fix-ECMAScript6BestPractices branch 2 times, most recently from 0e5498a to e6ca9a8 Compare November 28, 2025 15:59

Pankraz76 commented Nov 28, 2025

View reviewed changes

[rewrite] apply ECMAScript6BestPractices

987c233

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Pankraz76 force-pushed the fix-ECMAScript6BestPractices branch from e6ca9a8 to 987c233 Compare November 28, 2025 16:05

Vincent Potucek added 12 commits November 30, 2025 12:44

[ECMAScript6BestPractices] prerequisite fix common-serve.js

cd3f993

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

8c83dd9

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

99a2a52

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

e38991b

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

777aee0

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

7dbec54

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

84680f3

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

30a7f46

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

dd49e92

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

617e2bd

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

3648a39

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

7d1eb76

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Vincent Potucek added 10 commits November 30, 2025 14:02

[rewrite] apply ECMAScript6BestPractices

6cc4dcc

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

b48205f

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

eb97996

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

15fd403

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

e2dfdc4

Signed-off-by: Vincent Potucek <vpotucek@me.com>

[rewrite] apply ECMAScript6BestPractices

e5d81a3

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Merge remote-tracking branch 'origin/fix-ECMAScript6BestPractices-fix…

f558260

…-common-serve' into fix-ECMAScript6BestPractices-fix-common-serve # Conflicts: # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js

Merge branch 'fix-ECMAScript6BestPractices-fix-common-serve' into fix…

42423fe

…-ECMAScript6BestPractices # Conflicts: # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js

[rewrite] apply ECMAScript6BestPractices

b6439c1

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Merge remote-tracking branch 'origin/fix-ECMAScript6BestPractices' in…

9907ca7

…to fix-ECMAScript6BestPractices # Conflicts: # gradle/rewrite.gradle # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js # lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-serve.js

Pankraz76 closed this Dec 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rewrite] apply `ECMAScript6BestPractices`#2768

[rewrite] apply `ECMAScript6BestPractices`#2768
Pankraz76 wants to merge 23 commits into
diffplug:mainfrom
Pankraz76:fix-ECMAScript6BestPractices

Pankraz76 commented Nov 24, 2025 •

edited

Loading

Uh oh!

Pankraz76 Nov 24, 2025

Uh oh!

Uh oh!

Pankraz76 commented Nov 24, 2025

Uh oh!

Pankraz76 Nov 24, 2025 •

edited

Loading

Uh oh!

Pankraz76 commented Nov 27, 2025

Uh oh!

Pankraz76 Nov 28, 2025 •

edited

Loading

Uh oh!

Pankraz76 commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Pankraz76 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pankraz76 commented Nov 24, 2025

Uh oh!

Pankraz76 Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Nov 27, 2025

Uh oh!

Pankraz76 Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Pankraz76 commented Nov 24, 2025 •

edited

Loading

Pankraz76 Nov 24, 2025 •

edited

Loading

Pankraz76 Nov 28, 2025 •

edited

Loading