Skip to content

[prone] apply -XepDisableAllWarnings#2753

Closed
Pankraz76 wants to merge 0 commit into
diffplug:mainfrom
Pankraz76:fix-XepDisableAllWarnings
Closed

[prone] apply -XepDisableAllWarnings#2753
Pankraz76 wants to merge 0 commit into
diffplug:mainfrom
Pankraz76:fix-XepDisableAllWarnings

Conversation

@Pankraz76
Copy link
Copy Markdown

@Pankraz76 Pankraz76 commented Nov 21, 2025

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

Comment thread gradle/error-prone.gradle Outdated

tasks.withType(JavaCompile).configureEach {
options.errorprone {
disableAllWarnings = true // https://github.com/diffplug/spotless/issues/2745
Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @nedtwigg now i know why all other projects have this activated ^^.

Still picnic causing this to fail having found some strange bug.

Comment thread gradle/error-prone.gradle Outdated
apply plugin: 'net.ltgt.errorprone'

dependencies {
// errorprone('com.google.errorprone:error_prone_core:2.43.0') bug ErrorProneJavacPlugin has been compiled by a more recent version of the Java Runtime (class file version 65.0
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the bump to v.44 causing jdk compiling issue which seems strange considering patch scope.

@Pankraz76
Copy link
Copy Markdown
Author

item:

Scanning sources in project :
Using active styles []
There were problems parsing some source files, run with --info to see full stack traces
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json

Exception in thread "Worker-0" java.lang.NoClassDefFoundError: org/eclipse/osgi/framework/log/FrameworkLogEntry
	at org.eclipse.core.internal.runtime.PlatformLogWriter.getLog(PlatformLogWriter.java:90)
	at org.eclipse.core.internal.runtime.PlatformLogWriter.logging(PlatformLogWriter.java:48)
	at org.eclipse.core.internal.runtime.RuntimeLog.log(RuntimeLog.java:99)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:91)
Caused by: java.lang.ClassNotFoundException: org.eclipse.osgi.framework.log.FrameworkLogEntry
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
	at com.diffplug.spotless.FeatureClassLoader.findClass(FeatureClassLoader.java:79)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	... 4 more
Caused by: java.lang.ClassNotFoundException: org.eclipse.osgi.framework.log.FrameworkLogEntry


> Task :rewriteRun
All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck

@Pankraz76 Pankraz76 closed this Nov 21, 2025
@Pankraz76 Pankraz76 force-pushed the fix-XepDisableAllWarnings branch from 2208f0b to e4edf85 Compare November 21, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant