[prone] Apply errorprone#2689
Merged
Merged
Conversation
Pankraz76
force-pushed
the
fix-disableAllChecks
branch
2 times, most recently
from
e1057d7 to
93cc946
Compare
Member
|
it's not too big, but it does have a merge conflict |
Pankraz76
force-pushed
the
fix-disableAllChecks
branch
3 times, most recently
from
adebb76 to
9f7af1f
Compare
Pankraz76
force-pushed
the
fix-disableAllChecks
branch
from
9f7af1f to
2ec4ce0
Compare
Pankraz76
commented
Oct 21, 2025
| - tech.picnic.errorprone.refasterrules.TimeRulesRecipes | ||
| # - org.openrewrite.java.migrate.lang.FindVirtualThreadOpportunities # don't want to use: https://github.com/diffplug/spotless/pull/2684#discussion_r2433831887 | ||
| --- | ||
| name: com.diffplug.spotless.openrewrite.SpotlessFormat |
Author
There was a problem hiding this comment.
imho no recipe uses the style, also this fully covered by spotless so actually no need to keep.
Pankraz76
commented
Oct 21, 2025
| dependencies { | ||
| errorprone('com.google.errorprone:error_prone_core:2.42.0') | ||
| errorprone('tech.picnic.error-prone-support:error-prone-contrib:0.25.0') | ||
| constraints { |
Author
There was a problem hiding this comment.
seems like we dont need this to pass prone convention.
Author
|
rebase, thanks for teamwork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if too large can split as all patches:
reproducer: cycle until no changes:
./gradlew clean spotlessApply build -x testunused will review a lot of bugs and API stuff we must resolve these issues somehow, as it has high lvl API impact.