fix(rn): prevent duplicate radio/checkbox change events - #2546
Open
yandadaFreedom wants to merge 12 commits into
Open
fix(rn): prevent duplicate radio/checkbox change events#2546yandadaFreedom wants to merge 12 commits into
yandadaFreedom wants to merge 12 commits into
Conversation
hiyuki
reviewed
Jul 14, 2026
hiyuki
reviewed
Aug 25, 2026
|
|
||
| const onTap = (evt: NativeSyntheticEvent<TouchEvent>) => { | ||
| bindtap && bindtap(getCustomEvent('tap', evt, { layoutRef }, props)) | ||
| markLabelControlHandled(evt) |
Collaborator
There was a problem hiding this comment.
markLabelControlHandled(evt) 建议放到业务 bindtap 之前。RN 的事件分发会用 guarded callback 隔离单个 listener 的异常；如果 bindtap 同步抛错，当前函数会在写入标记前退出，但原始事件仍可能继续冒泡到 label，导致 label 再执行 triggerChange，出现异常路径下状态仍被切换的情况。建议顺序调整为 markLabelControlHandled(evt) → bindtap(...) → onChange(evt)；mpx-checkbox.tsx 中的同处逻辑也请同步调整。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.