Generalizing ser/deser to use traits#12
Open
andrew-manifold wants to merge 10 commits intodicej:masterfrom
Open
Generalizing ser/deser to use traits#12andrew-manifold wants to merge 10 commits intodicej:masterfrom
andrew-manifold wants to merge 10 commits intodicej:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A much belated follow up to address the issues from this PR. If this is accepted then I'll close out the older PR. I was never able to figure out the underlying issue in
unsafeland so opted to eventually go a safer but still quite flexible approach. Instead of having a hard requirement to usebincodeexplicitly under the hood, serialization & deserialization are now managed viaShmDeserializer,ShmZeroCopyDeserializerandShmSerializertraits. The api is admittedly a bit more verbose then the original but the benefit is that now users can customize the ser backend while keeping theipmpscapi untouched. For example, below is the trait impl for speedyunit tests pass as do the benchmarking tests in
ipc-benchmarks. Additionally included is a default set ofbincodewrapper traits to work with existing primitives (String,Vecetc) but the wrapper can be skipped for net new structs