Skip to content

fix: map iso8601 to gregory calendar #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KaiVandivier wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: map iso8601 to gregory calendar #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb54032
fix: map iso8601 to gregory calendar
KaiVandivier May 12, 2026
4e4ce60
ci: update workflows
KaiVandivier May 12, 2026
d3551d5
ci: fix again
KaiVandivier May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/dhis2-verify-commits.yml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ jobs:
lint-pr-title:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: c-hive/gha-yarn-cache@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'yarn'
- run: yarn install --frozen-lockfile
- id: commitlint
run: echo ::set-output name=config_path::$(node -e "process.stdout.write(require('@dhis2/cli-style').config.commitlint)")
Expand All @@ -21,10 +24,13 @@ jobs:
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, '[skip commit-lint]') }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: c-hive/gha-yarn-cache@v1
- uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'yarn'
- run: yarn install --frozen-lockfile
- id: commitlint
run: echo ::set-output name=config_path::$(node -e "process.stdout.write(require('@dhis2/cli-style').config.commitlint)")
Expand Down
16 changes: 5 additions & 11 deletions i18n/en.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2024-08-27T05:56:11.774Z\n"
"PO-Revision-Date: 2024-08-27T05:56:11.774Z\n"
"POT-Creation-Date: 2026-05-12T17:09:29.373Z\n"
"PO-Revision-Date: 2026-05-12T17:09:29.374Z\n"

msgid "Couldn't find a monthly period for weekly period id \"{{periodId}}\""
msgstr "Couldn't find a monthly period for weekly period id \"{{periodId}}\""
Expand Down Expand Up @@ -45,18 +45,12 @@ msgstr ""
msgid "Unrecognized date, received \"{{date}}\""
msgstr "Unrecognized date, received \"{{date}}\""

msgid "Year {{year}} is out of range."
msgstr "Year {{year}} is out of range."

msgid "Month {{month}} is out of range | 1 <= {{month}} <= 12."
msgstr "Month {{month}} is out of range | 1 <= {{month}} <= 12."

msgid "Day {{day}} is out of range | 1 <= {{day}} <= {{daysInMonth}}."
msgstr "Day {{day}} is out of range | 1 <= {{day}} <= {{daysInMonth}}."

msgid "Date is not given"
msgstr "Date is not given"

msgid "Invalid date in specified calendar"
msgstr "Invalid date in specified calendar"

msgid "Date {{dateString}} is less than the minimum allowed date {{minDateString}}."
msgstr "Date {{dateString}} is less than the minimum allowed date {{minDateString}}."

Expand Down
2 changes: 1 addition & 1 deletion src/constants/dhis2CalendarsMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const dhis2CalendarsMap: Record<string, SupportedCalendar> = {
coptic: 'coptic',
gregorian: 'gregory',
islamic: 'islamic',
iso8601: 'iso8601',
iso8601: 'gregory',
// 'Julian': 'julian', // this is not supported by Temporal
nepali: 'nepali',
thai: 'buddhist',
Expand Down
Loading