chore: remove the Docker Sandboxes AI workspace setup - #385
Draft
HendrikThePendric wants to merge 3 commits into
Draft
HendrikThePendric wants to merge 3 commits into
HendrikThePendric wants to merge 3 commits into
Conversation
The sandbox setup is per-developer, not per-project: which editor and git UI belong in the image depends on who is driving it, and the same setup is wanted on projects that have no config of their own. It moves to a personal repo. Removes .sbx/, scripts/sbx.sh, docs/claude-sandboxes.md, the sbx:* package scripts, and the sandbox references in README.md and CLAUDE.md. The .gitignore entries stay — they cover generated files regardless of what generates them — but the comments naming the sandbox are dropped. The pre-commit hook keeps its RUN_PRE_COMMIT_HOOK=0 escape hatch, now described in general terms instead of naming the sandbox clone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
🚀 Deployed on https://pr-385.event-visualizer.netlify.dhis2.org |
HendrikThePendric
force-pushed
the
chore/remove-docker-sandbox-config
branch
from
September 17, 2026 12:19
485d926 to
33ede46
Compare
| .claude/settings.local.json | ||
| # Installed by `playwright-cli install --skills`, not authored here | ||
| .claude/skills/playwright-cli | ||
| cypress/downloads |
Collaborator
Author
There was a problem hiding this comment.
This was simply a duplicate line that was removed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements N/A
Description
This PR removes virtually all Docker Sandbox related code from the repo. What is left are a few minor things:
.gitignoreentries that will prevent polluting the repo if a developer ends up using similar (self-managed) tooling as we did in the sandboxesRUN_PRE_COMMIT_HOOKenv var. This is a flag that can be used to lint a commit title but skip the code-linting. This is useful in general if you let Claude do commits, because it is configured to always finish with linting and testing. So then doing it in the pre-commit is a bit of a waste of time and energy. So we need a way to lint the commit but not the code in the pre-commit. For pre-push we don't need this, because--no-verifycan be used.Background
For a while we've shipped some scripts that enable running Claude in a Docker Sandbox with this repo. It proved to be impossible to get to a stable solution that's both convenient and secure:
node_modulesdir (so a sub-directory override from the mount. This kept breaking when runningpnpm installon the host. And ultimately some nasty code can still end up on the host filesystem so it was inherently insecure.A much better solution is to bring the dev tools - in my case NeoVim with a shedload of plugins and LazyGit - into the sandbox. This way you can have a stable solution thats both convenient and secure. However, this makes it a developer specific solution rather than a repo-specific one. So the Sandbox setup needs to be removed from the repo and moved to a separate repo.
Quality checklist
ToDos