Conversation
Now it's completely separated from the action buttons, so the logic can be simpler.
The modal should work in the same way as the Options modal. The Done button simply closes the modal while all changes are stored on the fly.
Contributor
|
🚀 Deployed on https://pr-369.event-visualizer.netlify.dhis2.org |
|
edoardo
marked this pull request as draft
September 7, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-XXXX
Description
The redesign replaces the previous 4th action button with a plain statement of what the visualization shows:
The modal becomes two radio cards — Count (default) and Custom value — where the second expands to reveal the item list and the aggregation dropdown.
The list is no longer filtered by program stage, and the custom value survives switching output type.
The new component lives in the bottom bar; the custom value is independent of output type; the stage-mismatch handling is removed entirely.
Quality checklist
Add N/A to items that are not applicable and check them.
Notes
The radio cards reuse the same component introduced for the grouping feature.
For this reason the styling of the help text does not match entirely the prototype.
@cooper-joe can you review this part and see if the styles can be reused?
Screenshots
No label/button until the outputType is chosen:
Label for LL:
Cell value button for PT (no custom value selected):
Cell value button for PT (with custom value selected):
Cell value modal (no custom value selected, count is default):
Cell value modal (custom value selected):
