feat: auto-discover Quick Start projects - #96
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c013233897
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| foreach (var directory in EnumerateWorkspaceDirectories(workspace)) | ||
| { | ||
| DiscoverDotNetProjects(workspace, directory, discovered); |
There was a problem hiding this comment.
Move recursive discovery off the UI thread
When opening a large monorepo or a workspace on slow/network storage, this loop walks and probes every non-ignored directory synchronously. DevSpaceDashboard calls it from its constructor, and the refresh click handler also invokes it directly, so the Avalonia UI cannot render or respond until the entire scan completes; run discovery asynchronously with cancellation or otherwise bound the traversal before updating Profiles on the UI thread.
Useful? React with 👍 / 👎.
| Profiles = DevBoard.DevSpaces.DevSpaceProjectDiscovery.Discover( | ||
| WorkspacePath, | ||
| DevBoard.DevSpaces.DevSpaceProfileSettings.Instance.Profiles); |
There was a problem hiding this comment.
Let session rows resolve discovered profile icons
After a user starts any discovered profile, its terminal title includes the generated icon, but DevSpaceDashboardSessionRow.ResolveProfileIcon searches only DevSpaceProfileSettings.Instance.Profiles; discovered profiles exist only in this dashboard snapshot. The active-terminal row therefore reports HasIcon == false, fails to strip the icon from DisplayTitle, and bypasses the dedicated emoji-font element, unlike manually configured profiles. Pass the discovered profile/icon information into session-row resolution or otherwise include Profiles in that lookup.
Useful? React with 👍 / 👎.
Summary
angular.jsonand launch them with pnpm/yarn/npm based on workspace files↻actionVerification
prunebehavior sourcegit-scm/sourcegit#590: passedStore MSIX is a separate workflow and is still running at the time of this update.